Skip to content

Module resolver should not filter which package.json to use based on a non-empty "name" - #22211

Closed
Jarred-Sumner wants to merge 1 commit into
mainfrom
jarred/use-nearest-package-json
Closed

Jarred-Sumner wants to merge 1 commit into
mainfrom
jarred/use-nearest-package-json

Conversation

@Jarred-Sumner

Copy link
Copy Markdown
Collaborator

What does this PR do?

Node doesn't do this. esbuild doesn't do this. Why do we? Probably some micro-optimization from 3 years ago.

How did you verify your code works?

CI

@robobun

robobun commented Aug 28, 2025 •

Copy link
Copy Markdown
Collaborator
Updated 5:44 AM PT - Aug 28th, 2025

❌ @Jarred-Sumner, your commit d862105 has 3 failures in Build #24151:


🧪   To try this PR locally:

bunx bun-pr 22211

That installs a local version of the PR into your bun-22211 executable, so you can run:

bun-22211 --bun

@Jarred-Sumner

Copy link
Copy Markdown
Collaborator Author

Closing in favor of #22231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants